Use LDFLAGS instead of install_name_tool#2
Use LDFLAGS instead of install_name_tool#2radarhere wants to merge 1 commit intofreakboy3742:zlib-ng-with-sipfrom
Conversation
12cc5e6 to
554a85d
Compare
|
@radarhere I agree that it would be preferable to use a time-of-compilation configuration flag to address this problem. The problem I see with this approach is that it results in the If we can convinced zlib-ng maintainers to expose the install name as a direct configuration option, that would enable a much cleaner solution - but that obviously requires a patch upstream. Interestingly, an iOS build requires patching some libraries, and multibuild has already been updated to support patching official sources. As a variant on this approach, it might be worth developing a macOS patch zlib-ng so we can explicitly specify an install name as part of the Pillow build, and then work to submit that patch upstream. |
Ok, I've given it a try - zlib-ng/zlib-ng#1867 |
Suggestion for python-pillow#8673
After looking at https://github.com/zlib-ng/zlib-ng/blob/287c4dce22a3244a0e2602d9e5bf0929df74fd27/configure#L473, I thought of using flags as an alternative to using
install_name_tool.You may or may not think this is a better solution, just thought I'd offer it.